Refactored assetclass

assetclass.php

@@ -8,8 +8,68 @@ SPDX-License-Identifier: GPL-3.0-or-later
 *****************************************************************************/
 	
 include("includes.php");
+
+if (isset($_REQUEST['id'])) {
+    $id = (int) $_REQUEST['id'] or $id = 0;
+}
+
+// ========== ACTIONS START ===================================================
+switch ($submit = form_get_action()) {
+
+    case NULL: break;
+
+    case 'add':   $action = ACT_ADD; break;
+    case 'view':  $action = ACT_VIEW; break;
+    case 'edit':  $action = ACT_EDIT; break;
+    case 'del':   $action = ACT_DELETE; break;
+
+    case 'insert':
+        $name = sanitize($_POST['assetclass_name']);
+        $description = sanitize($_POST['assetclass_description']);
+        $group_id = sanitize($_POST['assetclassgroup_id']);
+
+        $sql = "INSERT INTO assetclass
+                      (assetclass_name, assetclass_description, assetclassgroup_id)
+            VALUE
+                (?, ?, ?)";
+        $sth = $dbh->prepare($sql);
+        $sth->execute([$name, $description, $group_id]);
+        $id = $dbh->lastInsertId();
+        $action = ACT_VIEW;
+        break;
+
+    case 'update':
+        $name = sanitize($_POST['assetclass_name']);
+        $description = sanitize($_POST['assetclass_description']);
+        $group_id = sanitize($_POST['assetclassgroup_id']);
+
+        $sql = "UPDATE assetclass SET
+                    assetclass_name=?, assetclass_description=?,
+                    assetclassgroup_id=?
+                WHERE assetclass_id=?";
+        $sth = $dbh->prepare($sql);
+        $sth->execute([$name, $description, $group_id, $id]);
+        $action = ACT_VIEW;
+        break;
+
+    case 'delete':
+        $sth = $dbh->prepare("DELETE FROM assetclass WHERE assetclass_id=?");
+        $sth->execute([$id]);
+        $action = ACT_DEFAULT;
+        break;
+
+    default:
+        $g_error->Add(submit_error($submit));
+        $valid = FALSE;
+}
+
+// ========== ACTIONS END =====================================================
+
 include("header.php");
-			
+
+if ($action == ACT_DEFAULT):
+// ========== VARIANT: default behavior =======================================
+
 $sql = "SELECT c.assetclass_id AS id, c.assetclass_name AS name, c.assetclassgroup_id AS group_id,
             g.assetclassgroup_name AS group_name, g.assetclassgroup_color AS color,
             COUNT(a.asset_id) AS count_asset
@@ -23,5 +83,77 @@ $smarty->assign("assetclasses", $sth->fetchAll(PDO::FETCH_ASSOC));
 
 $smarty->display("assetclass.tpl");
 
-include("footer.php");
+elseif ($action == ACT_ADD):
+// ========== VARIANT: add record =============================================
+
+if (isset($_GET['assetclassgroup_id'])) {
+    $group_id = sanitize($_GET['assetclassgroup_id']);
+} else {
+    $group_id = '';
+}
+$smarty->assign("group_id", $group_id);
+$smarty->assign("assetclassgroup_options", db_get_options_assetclassgroup());
+
+$smarty->display("assetclassadd.tpl");
+
+elseif ($action == ACT_VIEW):
+// ========== VARIANT: view single record =====================================
+
+$sql = "SELECT a.assetclass_id, a.assetclass_name, g.assetclassgroup_id,
+            a.assetclass_description,
+            g.assetclassgroup_name, g.assetclassgroup_color
+        FROM assetclass AS a LEFT OUTER JOIN assetclassgroup AS g USING (assetclassgroup_id)
+        WHERE a.assetclass_id=?";
+$sth = $dbh->prepare($sql);
+$sth->execute([$id]);
+$smarty->assign("assetclass", $sth->fetch(PDO::FETCH_OBJ));
+
+$sql = "SELECT asset_id, asset_name,
+            CONCAT(LEFT(asset_info, 80), IF(CHAR_LENGTH(asset_info)>80,'...','')) AS asset_info
+        FROM asset
+        WHERE assetclass_id=?
+        ORDER BY asset_name";
+$sth = $dbh->prepare($sql);
+$sth->execute([$assetclass_id]);
+$smarty->assign("assets", $sth->fetchAll(PDO::FETCH_ASSOC));
+
+$smarty->display("assetclassview.tpl");
+
+elseif ($action == ACT_EDIT):
+// ========== VARIANT: edit single record =====================================
+
+$sql = "SELECT assetclass_id AS id, assetclass_name AS name,
+            assetclass_description AS description,
+            assetclassgroup_id AS group_id
+        FROM assetclass
+        WHERE assetclass_id=?";
+$sth = $dbh->prepare($sql);
+$sth->execute([$id]);
+$smarty->assign("assetclass", $sth->fetch(PDO::FETCH_OBJ));
+$smarty->assign("assetclassgroup_options", db_get_options_assetclassgroup());
+$smarty->display("assetclassedit.tpl");
+
+elseif ($action == ACT_DELETE):
+// ========== VARIANT: delete record ==========================================
+
+$sql = "SELECT assetclass_id AS id, assetclass_name AS name
+        FROM assetclass
+        WHERE assetclass_id=?";
+$sth = $dbh->prepare($sql);
+$sth->execute([$id]);
+$smarty->assign("assetclass", $sth->fetch(PDO::FETCH_OBJ));
+
+$smarty->display("assetclassdel.tpl");
+
+else:
+// ========== ERROR UNKNOWN VARIANT ===========================================
+
+echo "<p>Unknown function call: Please report to system development!</p>\n";
+
+endif; // $action == ...
+// ========== END OF VARIANTS =================================================
+
+$smarty->display('footer.tpl');
+
+// include("footer.php");
 ?>

assetclassadd.php

@@ -1,20 +0,0 @@
-<?php
-/*****************************************************************************
-IP Reg, a PHP/MySQL IPAM tool
-Copyright (C) 2007-2009 Wietse Warendorff (up to v0.5)
-Copyright (C) 2011-2023 Thomas Hooge
-
-SPDX-License-Identifier: GPL-3.0-or-later
-*****************************************************************************/
-
-include("includes.php");
-
-if((isset($_GET['assetclassgroup_id'])) ? $assetclassgroup_id = sanitize($_GET['assetclassgroup_id']) : $assetclassgroup_id = "");
-
-include("header.php");
-
-$smarty->assign("assetclassgroup_options", db_get_options_assetclassgroup());
-$smarty->display("assetclassadd.tpl");
-		
-include("footer.php");
-?>

assetclassdel.php

@@ -1,26 +0,0 @@
-<?php
-/*****************************************************************************
-IP Reg, a PHP/MySQL IPAM tool
-Copyright (C) 2007-2009 Wietse Warendorff (up to v0.5)
-Copyright (C) 2011-2023 Thomas Hooge
-
-SPDX-License-Identifier: GPL-3.0-or-later
-*****************************************************************************/
-
-include("includes.php");
-
-$assetclass_id = sanitize($_GET['assetclass_id']);
-
-include("header.php");
-
-$sql = "SELECT assetclass_id AS id, assetclass_name AS name
-        FROM assetclass
-	WHERE assetclass_id=?";
-$sth = $dbh->prepare($sql);
-$sth->execute([$assetclass_id]);
-$smarty->assign("assetclass", $sth->fetch(PDO::FETCH_OBJ));
-
-$smarty->display("assetclassdel.tpl");
-
-include("footer.php");
-?>

assetclassedit.php

@@ -1,30 +0,0 @@
-<?php
-/*****************************************************************************
-IP Reg, a PHP/MySQL IPAM tool
-Copyright (C) 2007-2009 Wietse Warendorff (up to v0.5)
-Copyright (C) 2011-2023 Thomas Hooge
-
-SPDX-License-Identifier: GPL-3.0-or-later
-*****************************************************************************/
-
-include("includes.php");
-
-$assetclass_id = sanitize($_GET['assetclass_id']);
-include("header.php");
-		
-$sql = "SELECT assetclass_id AS id, assetclass_name AS name,
-            assetclass_description AS description,
-            assetclassgroup_id AS group_id
-        FROM assetclass
-        WHERE assetclass_id=?";
-$sth = $dbh->prepare($sql);
-$sth->execute([$assetclass_id]);
-
-$smarty->assign("assetclass", $sth->fetch(PDO::FETCH_OBJ));
-
-$smarty->assign("assetclassgroup_options", db_get_options_assetclassgroup());
-
-$smarty->display("assetclassedit.tpl");
-
-include("footer.php");
-?>

assetclassview.php

@@ -1,37 +0,0 @@
-<?php
-/*****************************************************************************
-IP Reg, a PHP/MySQL IPAM tool
-Copyright (C) 2007-2009 Wietse Warendorff (up to v0.5)
-Copyright (C) 2011-2023 Thomas Hooge
-
-SPDX-License-Identifier: GPL-3.0-or-later
-*****************************************************************************/
-
-include("includes.php");
-
-$assetclass_id = sanitize($_GET['assetclass_id']);
-
-include("header.php");
-
-$sql = "SELECT a.assetclass_id, a.assetclass_name, g.assetclassgroup_id,
-            a.assetclass_description,
-            g.assetclassgroup_name, g.assetclassgroup_color
-	FROM assetclass AS a LEFT OUTER JOIN assetclassgroup AS g USING (assetclassgroup_id)
-	WHERE a.assetclass_id=?";
-$sth = $dbh->prepare($sql);
-$sth->execute([$assetclass_id]);
-$smarty->assign("assetclass", $sth->fetch(PDO::FETCH_OBJ));
-
-$sql = "SELECT asset_id, asset_name,
-            CONCAT(LEFT(asset_info, 80), IF(CHAR_LENGTH(asset_info)>80,'...','')) AS asset_info
-	FROM asset
-	WHERE assetclass_id=?
-	ORDER BY asset_name";
-$sth = $dbh->prepare($sql);
-$sth->execute([$assetclass_id]);
-$smarty->assign("assets", $sth->fetchAll(PDO::FETCH_ASSOC));
-
-$smarty->display("assetclassview.tpl");
-
-include("footer.php");
-?>

lang/de.php

@@ -45,6 +45,7 @@ $lang = array(
     'lang_statistics' => 'Statistik',
     'lang_subitem' => 'Sub-Item',
     'lang_submit' => 'Absenden',
+    'lang_save' => 'Speichern',
     'lang_unassigned' => 'Nicht zugeordnet',
     'lang_warning' => 'Warnung',
     'lang_description' => 'Bezeichnung',
@@ -134,6 +135,7 @@ $lang = array(
     'lang_nat_type_1' => 'Verbergen',
     'lang_nat_type_2' => 'Statisch',
     'lang_nat_type_3' => 'Dynamisch',
+    'lang_nat_none' => 'Es sind keine NAT-Regeln vorhanden',
 
     'lang_search_results_found' => 'Anzahl der gefundenen Ergebnisse: ',
 

lang/en.php

@@ -45,6 +45,7 @@ $lang = array(
     'lang_statistics' => 'Statistics',
     'lang_subitem' => 'Sub-Item',
     'lang_submit' => 'Submit',
+    'lang_save' => 'Save',
     'lang_unassigned' => 'Unassigned',
     'lang_warning' => 'Warning',
     'lang_description' => 'Description',
@@ -134,6 +135,7 @@ $lang = array(
     'lang_nat_type_1' => 'Hide',
     'lang_nat_type_2' => 'Static',
     'lang_nat_type_3' => 'Dynamic',
+    'lang_nat_none' => 'There are no nat rules defined',
 
     'lang_search_results_found' => 'Total results found',
 

submit.php

@@ -119,7 +119,7 @@ if (isset($_POST['add'])) {
 
             header_location("assetview.php?asset_id=" . $dbh->lastInsertId());
             break;
-
+/* refactored
         case ("assetclass") :
             $name = sanitize($_POST['assetclass_name']);
             $description = sanitize($_POST['assetclass_description']);
@@ -133,7 +133,7 @@ if (isset($_POST['add'])) {
             $sth->execute([$name, $description, $group_id]);
 
             header_location("assetclassview.php?assetclass_id=" . $dbh->lastInsertId());
-            break;
+            break; */
 
         case ("assetclassgroup") :
             $name = sanitize($_POST['acg_name']);
@@ -398,7 +398,7 @@ if (isset($_POST['del'])) {
 
             header_location("asset.php");
             break;
-
+/* refactored
         case ("assetclass") :
             $assetclass_id = sanitize($_POST['assetclass_id']);
 
@@ -406,7 +406,7 @@ if (isset($_POST['del'])) {
             $sth->execute([$assetclass_id]);
 
             header_location("assetclass.php");
-            break;
+            break; */
 
         case ("assetclassgroup") :
             $assetclassgroup_id = sanitize($_POST['assetclassgroup_id']);
@@ -548,7 +548,7 @@ if (isset($_POST['edit'])) {
                            $asset_id]);
 
             header_location("assetview.php?asset_id=" . $asset_id);
-
+/* refactored
         case ("assetclass") :
             $id = sanitize($_POST['assetclass_id']);
             $name = sanitize($_POST['assetclass_name']);
@@ -563,7 +563,7 @@ if (isset($_POST['edit'])) {
             $sth->execute([$name, $description, $group_id, $id]);
 
             header_location("assetclassview.php?assetclass_id=" . $id);
-            break;
+            break; */
 
         case ("assetclassgroup") :
             $acg_id = sanitize($_POST['acg_id']);

tpl/asset.tpl

@@ -40,7 +40,7 @@
         <a href="assetview.php?asset_id={$asset.asset_id}">{$asset.asset_name}</a>
     </td>
     <td class="value">
-        <a href="assetclassview.php?assetclass_id={$asset.assetclass_id}">{$asset.assetclass_name}</a>
+        <a href="assetclass.php?f=view&id={$asset.assetclass_id}">{$asset.assetclass_name}</a>
     </td>
     <td class="value">
         {$asset.asset_info}

tpl/assetadd.tpl

@@ -27,7 +27,7 @@
         {$lang_asset_name}
     </td>
     <td class="value">
-        <input type="text" name="asset_name">
+        <input type="text" name="asset_name" autofocus>
     </td>
 </tr>
 <tr>

tpl/assetclass.tpl

@@ -6,7 +6,7 @@
     </td>
     <td align="right">
 {if $suser_add || $suser_admin}
-        <a href="assetclassadd.php"><img src="image.php?icon=add" alt="{$lang_assetclass_add}" {if $suser_tooltips}title="{$lang_assetclass_add}" {/if}/></a>
+        <a href="assetclass.php?f=add"><img src="image.php?icon=add" alt="{$lang_assetclass_add}" {if $suser_tooltips}title="{$lang_assetclass_add}" {/if}/></a>
 {/if}
     </td>
 </tr>
@@ -27,7 +27,7 @@
 {foreach item=assetclass from=$assetclasses}
 <tr>
     <td class="label">
-        <a href="assetclassview.php?assetclass_id={$assetclass.id}">{$assetclass.name}</a>
+        <a href="assetclass.php?f=view&id={$assetclass.id}">{$assetclass.name}</a>
     </td>
     <td class="value">
         <img src="image.php?color={$assetclass.color}" alt="#{$assetclass.color}">

tpl/assetclassadd.tpl

@@ -1,5 +1,4 @@
-<form method="POST" action="submit.php">
+<form method="POST" action="assetclass.php">
-<input type="hidden" name="add" value="assetclass">
 
 <table class="title">
 <tr>
@@ -8,7 +7,7 @@
     </td>
     <td align="right">
         <a href="#" onClick="history.go(-1)"><img src="image.php?icon=cancel" alt="{$lang_cancel}" {if $suser_tooltips}title="{$lang_cancel}" {/if}/></a>
-        <input type="image" src="image.php?icon=save" alt="{$lang_submit}" {if $suser_tooltips}title="{$lang_submit}" {/if}/>
+        <input type="image" name="submit[insert]" src="images/page_add.png" alt="{$lang_submit}" {if $suser_tooltips}title="{$lang_submit}" {/if}/>
     </td>
 </tr>
 </table>
@@ -27,7 +26,7 @@
         {$lang_assetclass_name}
     </td>
     <td class="value">
-        <input type="text" name="assetclass_name">
+        <input type="text" name="assetclass_name" autofocus>
     </td>
 </tr>
 <tr>

tpl/assetclassdel.tpl

@@ -1,6 +1,5 @@
-<form method="POST" action="submit.php">
+<form method="POST" action="assetclass.php">
-<input type="hidden" name="del" value="assetclass">
+<input type="hidden" name="id" value="{$assetclass->id}">
-<input type="hidden" name="assetclass_id" value="{$assetclass->id}">
 
 <table  class="title">
 <tr>
@@ -9,7 +8,7 @@
     </td>
     <td align="right">
         <a href="#" onClick="history.go(-1)"><img src="image.php?icon=cancel" alt="{$lang_cancel}" {if $suser_tooltips}title="{$lang_cancel}" {/if}/></a>
-        <input type="image" src="image.php?icon=shred" alt="{$lang_assetclass_del}" {if $suser_tooltips}title="{$lang_assetclass_del}" {/if}/>
+        <input type="image" name="submit[delete]" src="images/bin.png" alt="{$lang_assetclass_del}" {if $suser_tooltips}title="{$lang_assetclass_del}" {/if}/>
     </td>
 </tr>
 </table>
@@ -28,7 +27,7 @@
         {$lang_assetclass_name}
     </td>
     <td class="value">
-        <a href="assetclassview.php?assetclass_id={$assetclass->id}">{$assetclass->name}</a>
+        <a href="assetclass.php?f=view&id={$assetclass->id}">{$assetclass->name}</a>
     </td>
 </tr>
 </table>

tpl/assetclassedit.tpl

@@ -1,6 +1,5 @@
-<form method="POST" action="submit.php">
+<form method="POST" action="assetclass.php">
-<input type="hidden" name="edit" value="assetclass">
+<input type="hidden" name="id" value="{$assetclass->id}">
-<input type="hidden" name="assetclass_id" value="{$assetclass->id}">
 
 <table class="title">
 <tr>
@@ -10,7 +9,7 @@
     </td>
     <td align="right">
         <a href="#" onClick="history.go(-1)"><img src="image.php?icon=back" alt="{$lang_cancel}" {if $suser_tooltips}title="{$lang_cancel}" {/if}/></a>
-        <input type="image" src="image.php?icon=save" alt="{$lang_submit}" {if $suser_tooltips}title="{$lang_submit}" {/if}/>
+        <input type="image" name="submit[update]" src="images/page_save.png" alt="{$lang_save}" {if $suser_tooltips}title="{$lang_save}" {/if}/>
     </td>
 </tr>
 </table>

tpl/assetclassgroupadd.tpl

@@ -27,7 +27,7 @@
         {$lang_assetclassgroup_name}
     </td>
     <td class="value">
-        <input type="text" name="acg_name">
+        <input type="text" name="acg_name" autofocus>
     </td>
 </tr>
 <tr>

tpl/assetclassgroupview.tpl

@@ -69,7 +69,7 @@
         </td>
         <td class="value">
         {foreach item=assetclass from=$assetclasses}
-            <a href="assetclassview.php?assetclass_id={$assetclass.assetclass_id}">{$assetclass.assetclass_name}</a><br>
+            <a href="assetclass.php?f=view&id={$assetclass.assetclass_id}">{$assetclass.assetclass_name}</a><br>
         {/foreach}
         </td>
     </tr>

tpl/assetclassview.tpl

@@ -9,10 +9,10 @@
         <a href="assetadd.php?assetclass_id={$assetclass->assetclass_id}"><img src="image.php?icon=add" alt="{$lang_asset_add}" {if $suser_tooltips}title="{$lang_asset_add}" {/if}/></a>
 {/if}
 {if $suser_edit}
-        <a href="assetclassedit.php?assetclass_id={$assetclass->assetclass_id}"><img src="image.php?icon=edit" alt="{$lang_assetclass_edit}" {if $suser_tooltips}title="{$lang_asset_edit}" {/if}/></a>
+        <a href="assetclass.php?f=edit&id={$assetclass->assetclass_id}"><img src="image.php?icon=edit" alt="{$lang_assetclass_edit}" {if $suser_tooltips}title="{$lang_asset_edit}" {/if}/></a>
 {/if}
 {if $suser_delete}
-        <a href="assetclassdel.php?assetclass_id={$assetclass->assetclass_id}"><img src="image.php?icon=delete" alt="{$lang_assetclass_add}" {if $suser_tooltips}title="{$lang_asset_delete}" {/if}/></a>
+        <a href="assetclass.php?f=del&id={$assetclass->assetclass_id}"><img src="image.php?icon=delete" alt="{$lang_assetclass_add}" {if $suser_tooltips}title="{$lang_asset_delete}" {/if}/></a>
 {/if}
     </td>
 </tr>
@@ -33,7 +33,7 @@
     </td>
     <td class="value">
 {if $suser_edit}
-        <a href="assetclassview.php?assetclass_id={$assetclass->assetclass_id}">{$assetclass->assetclass_name}</a>
+        <a href="assetclass.php?f=view&id={$assetclass->assetclass_id}">{$assetclass->assetclass_name}</a>
 {/if}
     </td>
 </tr>

tpl/assetview.tpl

@@ -84,7 +84,7 @@
         {$lang_assetclass_name}
     </td>
     <td class="value">
-        <a href="assetclassview.php?assetclass_id={$asset->assetclass_id}">{$asset->assetclass_name}</a>
+        <a href="assetclass.php?f=view&id={$asset->assetclass_id}">{$asset->assetclass_name}</a>
     </td>
 </tr>
 </table>

tpl/nat.tpl

@@ -42,7 +42,7 @@
 </tr>
 {foreachelse}
 <tr>
-    <td colspan="3">
+    <td colspan="4">
         {$lang_nat_none}
     </td>
 </tr>